Moving ClassHelperTests into Kotlin #2716
Conversation
testng-core/src/test/kotlin/org/testng/internal/ClassHelperTest.kt
Outdated
Show resolved
Hide resolved
testng-core/src/test/kotlin/org/testng/internal/ClassHelperTest.kt
Outdated
Show resolved
Hide resolved
testng-core/src/test/kotlin/org/testng/internal/ClassHelperTest.kt
Outdated
Show resolved
Hide resolved
testng-core/src/test/kotlin/org/testng/internal/ClassHelperTest.kt
Outdated
Show resolved
Hide resolved
testng-core/src/test/kotlin/org/testng/internal/ClassHelperTest.kt
Outdated
Show resolved
Hide resolved
testng-core/src/test/kotlin/org/testng/internal/ClassHelperTest.kt
Outdated
Show resolved
Hide resolved
testng-core/src/test/kotlin/org/testng/internal/ClassHelperTest.kt
Outdated
Show resolved
Hide resolved
...ng-core/src/test/kotlin/org/testng/internal/samples/classhelper/issue1339/BabyPandaSample.kt
Outdated
Show resolved
Hide resolved
testng-core/src/test/kotlin/org/testng/reporters/jq/TimesPanelTest.kt
Outdated
Show resolved
Hide resolved
krmahadevan
force-pushed
the
classhelpertests_to_kotlin
branch
3 times, most recently
from
3216f11
to
b47bf57
Compare
testng-core/src/test/kotlin/org/testng/internal/ClassHelperTest.kt
Outdated
Show resolved
Hide resolved
testng-core/src/test/kotlin/org/testng/internal/ClassHelperTest.kt
Outdated
Show resolved
Hide resolved
testng-core/src/test/kotlin/org/testng/internal/ClassHelperTest.kt
Outdated
Show resolved
Hide resolved
testng-core/src/test/kotlin/org/testng/internal/ClassHelperTest.kt
Outdated
Show resolved
Hide resolved
...ng-core/src/test/kotlin/org/testng/internal/samples/classhelper/issue1339/BabyPandaSample.kt
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,9 @@ | |||
| package org.testng.internal.samples.classhelper.issue1339; | |||
|
|
|||
| open class GrandpaBearSample { | |||
There was a problem hiding this comment.
Is it working if sample classes are not open?
There was a problem hiding this comment.
I didnt understand this comment. The class cannot be extended if its not open and there are other samples which test the regular use case.
There was a problem hiding this comment.
You right "not" open means "final".
What about sealed?
The question behind: what is the best keyword?
There was a problem hiding this comment.
@juherr its still not clear what the question is. I have just ported the classes as they were from Java to Kotlin.
I don't quite understand what the expectations are here.
If these tests were sufficient in Java, are you saying that they arent when it comes to Kotlin ?
There was a problem hiding this comment.
sealed doesn't exist in java (not yet)
maybe sealed is better than public
it's a global kotlin question because we don't care for tests.
...ng-core/src/test/kotlin/org/testng/internal/samples/classhelper/issue1456/TestClassSample.kt
Outdated
Show resolved
Hide resolved
...e/src/test/kotlin/org/testng/internal/samples/classhelper/misamples/SuperHeroCapabilities.kt
Outdated
Show resolved
Hide resolved
krmahadevan
force-pushed
the
classhelpertests_to_kotlin
branch
2 times, most recently
from
b9cda1d
to
fc47f9e
Compare
|
@juherr - Fixed all the comments. Please take a look |
testng-core/src/test/kotlin/org/testng/internal/ClassHelperTest.kt
Outdated
Show resolved
Hide resolved
testng-core/src/test/kotlin/org/testng/internal/ClassHelperTest.kt
Outdated
Show resolved
Hide resolved
| return this | ||
| } | ||
|
|
||
| private fun newXmlClasses(vararg classes: KClass<*>): List<XmlClass> { |
There was a problem hiding this comment.
Don't know if it is possible with vararg but it could be awesome to use it like: classes.asXmlClasses()
testng-core/src/test/kotlin/org/testng/reporters/jq/TimesPanelTest.kt
Outdated
Show resolved
Hide resolved
krmahadevan
force-pushed
the
classhelpertests_to_kotlin
branch
from
fc47f9e
to
de410c3
Compare
krmahadevan
force-pushed
the
classhelpertests_to_kotlin
branch
from
de410c3
to
19aae7c
Compare
Fixes # .
Did you remember to?
CHANGES.txt./gradlew autostyleApplyWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.